From 2630ebcde18b2291a8859c724e968bcbb0e4730e Mon Sep 17 00:00:00 2001 From: "R. Timothy Edwards" Date: Mon, 4 Aug 2025 14:39:10 -0400 Subject: [PATCH] Reverted a change made to "select area" earlier in the year, which changed the behavior from selecting subcells if they are unexpanded to selecting subcells regardless of the expansion state. The change was short-sighted and the implementation hard to use. There is a need, I think, for a selection method that effectively unexpands instances, selects everything, and re-expands afterward. But it's not clear if it is better to select all touching instances or instances inside the box area; maybe only interacting instances (instances with non-space content inside the box). Regardless, it needs more thought, and meanwhile, the original behavior works better. --- VERSION | 2 +- select/selCreate.c | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/VERSION b/VERSION index 9aebba3a..2baafdef 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -8.3.535 +8.3.536 diff --git a/select/selCreate.c b/select/selCreate.c index 23c2ebdc..a7ed2cb9 100644 --- a/select/selCreate.c +++ b/select/selCreate.c @@ -474,14 +474,9 @@ SelectArea(scx, types, xMask, globmatch) else (void) DBCellCopyAllLabels(scx, types, xMask, SelectUse, &labelArea); /* Select cell uses. */ - /* NOTE: Changed 2/9/2025; Previously this was restricted to unexpanded - * cell instances, which is an unnecessary restriction. By changing "xMask" - * to "CU_DESCEND_ALL", this now only ever looks one level down and will - * select any instance that is a child of the edit cell, expanded or not. - */ if (TTMaskHasType(types, L_CELL)) - (void) DBCellCopyAllCells(scx, CU_DESCEND_ALL, SelectUse, &cellArea); + (void) DBCellCopyAllCells(scx, xMask, SelectUse, &cellArea); else { cellArea.r_xbot = 0;