From 1360f962a15662660dde858fb1ae621a6e9aa700 Mon Sep 17 00:00:00 2001 From: "Darryl L. Miles" Date: Sun, 29 Sep 2024 23:00:00 +0100 Subject: [PATCH] calma/CalmaRdcl.c: calmaFindCell() Call to function with fewer arguments than declared parameters The 'predefined' pointer argument to calmaFindCell() is for an optional return value, so must be NULL when feature is not used. Copilot Autofix rejected: newdef = calmaFindCell(newname, someSecondArgument); calma/CalmaRdcl.c 1c822652 (2020-12-04 16:56:51 -0500 1359) bool *predefined; /* If this cell was in memory before the GDS 1c822652 (2020-12-04 16:56:51 -0500 1360) * file was read, then this flag gets set. 1c822652 (2020-12-04 16:56:51 -0500 1361) */ commit 1c822652442ca3dc016efbbbce2c3052340bdd10 (tag: mpw-one-a, tag: 8.3.92) Date: Fri Dec 4 16:56:51 2020 -0500 CodeQL: https://github.com/dlmiles/magic/security/code-scanning/6 https://github.com/dlmiles/magic/security/code-scanning/5 --- calma/CalmaRdpt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/calma/CalmaRdpt.c b/calma/CalmaRdpt.c index 92bd9ef3..146f3276 100644 --- a/calma/CalmaRdpt.c +++ b/calma/CalmaRdpt.c @@ -267,7 +267,7 @@ calmaElementBoundary() he = HashFind(&calmaDefInitHash, newname); if (!HashGetValue(he)) { - newdef = calmaFindCell(newname, NULL); + newdef = calmaFindCell(newname, NULL, NULL); cifReadCellDef = newdef; DBCellClearDef(cifReadCellDef); DBCellSetAvail(cifReadCellDef); @@ -673,7 +673,7 @@ calmaElementPath() he = HashFind(&calmaDefInitHash, newname); if (!HashGetValue(he)) { - newdef = calmaFindCell(newname, NULL); + newdef = calmaFindCell(newname, NULL, NULL); cifReadCellDef = newdef; DBCellClearDef(cifReadCellDef); DBCellSetAvail(cifReadCellDef);