From e37e3f6793938a7039cd75c9debac6b9800b841e Mon Sep 17 00:00:00 2001
From: Matthias Koefferlein <matthias@koefferlein.de>
Date: Mon, 15 Jun 2020 01:37:03 +0200
Subject: [PATCH] Fixed doc flaw: child classes were not properly
 cross-referenced as return values or arguments. Need qualified names.

---
 src/lay/lay/layGSIHelpProvider.cc | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/lay/lay/layGSIHelpProvider.cc b/src/lay/lay/layGSIHelpProvider.cc
index 2307e7f3c..171b3fc6a 100644
--- a/src/lay/lay/layGSIHelpProvider.cc
+++ b/src/lay/lay/layGSIHelpProvider.cc
@@ -285,16 +285,6 @@ static DocumentationParser &cls_documentation (const gsi::ClassBase *cls)
   }
 }
 
-static const std::string &aliased_name (const gsi::ClassBase *cls)
-{
-  const std::string &alias = cls_documentation (cls).alias;
-  if (alias.empty ()) {
-    return cls->name ();
-  } else {
-    return alias;
-  }
-}
-
 static std::string make_qualified_name (const gsi::ClassBase *cls)
 {
   std::string qname;
@@ -703,9 +693,9 @@ type_to_s (const gsi::ArgType &a, bool linked, bool for_return)
       s += "new ";
     }
     if (linked) {
-      s += "<a href=\"" + escape_xml (class_doc_url (aliased_name (a.cls ()))) + "\">" + escape_xml (aliased_name (a.cls ())) + "</a>";
+      s += "<a href=\"" + escape_xml (class_doc_url (make_qualified_name (a.cls ()))) + "\">" + escape_xml (make_qualified_name (a.cls ())) + "</a>";
     } else {
-      s += aliased_name (a.cls ());
+      s += make_qualified_name (a.cls ());
     }
     break;
   case gsi::T_vector: