From 078aa3697453e026a7b71324a34f3f65ecf9dbdf Mon Sep 17 00:00:00 2001 From: Matthias Koefferlein Date: Sun, 3 Nov 2019 18:16:26 +0100 Subject: [PATCH 1/2] Issue #394 fixed: at least the toolbox layout should be fixed now --- src/laybasic/laybasic/layLayerToolbox.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/laybasic/laybasic/layLayerToolbox.cc b/src/laybasic/laybasic/layLayerToolbox.cc index 7a527989a..60f4e6420 100644 --- a/src/laybasic/laybasic/layLayerToolbox.cc +++ b/src/laybasic/laybasic/layLayerToolbox.cc @@ -530,7 +530,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (25, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("0px")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -539,7 +538,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (25, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("1px")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -548,7 +546,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (25, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("2px")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -557,7 +554,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (25, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("3px")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -572,7 +568,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (50, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("No Cross")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -581,7 +576,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (50, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("Cross")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -596,7 +590,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (50, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("Simple")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); @@ -605,7 +598,6 @@ LCPStylePalette::LCPStylePalette (QWidget *parent, const char *name) b->setMinimumSize (50, 16); b->setAlignment (Qt::AlignCenter); b->setLineWidth (1); - b->setSizePolicy (sp); b->setText (QObject::tr ("Marked")); connect (b, SIGNAL (clicked (int)), this, SLOT (button_clicked (int))); ll->addWidget (b); From 4f49447fe8cd9d1e635a4789f34928e7f0c928e5 Mon Sep 17 00:00:00 2001 From: Matthias Koefferlein Date: Sun, 3 Nov 2019 19:01:46 +0100 Subject: [PATCH 2/2] Fixed #393 (properly show DRC syntax errors) --- src/rba/rba/rbaUtils.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/rba/rba/rbaUtils.cc b/src/rba/rba/rbaUtils.cc index 9d199b53f..fa54e4af7 100644 --- a/src/rba/rba/rbaUtils.cc +++ b/src/rba/rba/rbaUtils.cc @@ -160,7 +160,13 @@ rba_check_error () // parse the backtrace to get the line number tl::BacktraceElement info; - if (! bt.empty ()) { + if (CLASS_OF (lasterr) == rb_eSyntaxError) { + // for syntax errors we try to parse the message + info = rba_split_bt_information (emsg.c_str (), emsg.size ()); + if (info.line == 0 && ! bt.empty ()) { + info = bt.front (); + } + } else if (! bt.empty ()) { // use the backtrace info = bt.front (); } else {