From 5929ea3bc6b8b597cd1a4959e10aac8f8cf444d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20K=C3=B6fferlein?= Date: Sat, 2 Apr 2022 16:07:25 +0200 Subject: [PATCH] Applied patch as discussed in #1040 (#1045) * Applied patch as discussed in #1040 * Adding extra compilation flags to extensions #1040 tlcore, dbcore and libcore did not have compilation flags. It failed compiling on Macos because it did not use C++11. Co-authored-by: Thomas Ferreira de Lima --- setup.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index d809be74c..a2631a25a 100644 --- a/setup.py +++ b/setup.py @@ -273,8 +273,6 @@ class Config(object): quote_path("-I" + os.path.join(bits, "curl", "include"))] else: return [] - elif platform.system() == "Darwin": - return [] else: return ["-Wno-strict-aliasing", # Avoids many "type-punned pointer" warnings "-std=c++11", # because we use unordered_map/unordered_set @@ -534,6 +532,7 @@ tl = Extension(config.root + '.tlcore', include_dirs=[_tl_path, _gsi_path, _pya_path], extra_objects=[config.path_of('_tl', _tl_path), config.path_of('_gsi', _gsi_path), config.path_of('_pya', _pya_path)], extra_link_args=config.link_args('tlcore'), + extra_compile_args=config.compile_args('tlcore'), sources=list(tl_sources)) # ------------------------------------------------------------------ @@ -547,6 +546,7 @@ db = Extension(config.root + '.dbcore', include_dirs=[_db_path, _tl_path, _gsi_path, _pya_path], extra_objects=[config.path_of('_db', _db_path), config.path_of('_tl', _tl_path), config.path_of('_gsi', _gsi_path), config.path_of('_pya', _pya_path)], extra_link_args=config.link_args('dbcore'), + extra_compile_args=config.compile_args('dbcore'), sources=list(db_sources)) # ------------------------------------------------------------------ @@ -560,6 +560,7 @@ lib = Extension(config.root + '.libcore', include_dirs=[_lib_path, _tl_path, _gsi_path, _pya_path], extra_objects=[config.path_of('_lib', _lib_path), config.path_of('_tl', _tl_path), config.path_of('_gsi', _gsi_path), config.path_of('_pya', _pya_path)], extra_link_args=config.link_args('libcore'), + extra_compile_args=config.compile_args('libcore'), sources=list(lib_sources)) # ------------------------------------------------------------------ @@ -573,6 +574,7 @@ rdb = Extension(config.root + '.rdbcore', include_dirs=[_rdb_path, _tl_path, _gsi_path, _pya_path], extra_objects=[config.path_of('_rdb', _rdb_path), config.path_of('_tl', _tl_path), config.path_of('_gsi', _gsi_path), config.path_of('_pya', _pya_path)], extra_link_args=config.link_args('rdbcore'), + extra_compile_args=config.compile_args('rdbcore'), sources=list(rdb_sources)) # ------------------------------------------------------------------