diff --git a/PWire.cc b/PWire.cc index 5cba7ef97..3591657b3 100644 --- a/PWire.cc +++ b/PWire.cc @@ -29,16 +29,11 @@ PWire::PWire(perm_string n, NetNet::PortType pt, ivl_variable_type_t dt) : name_(n), type_(t), port_type_(pt), data_type_(dt), - signed_(false), isint_(false), + signed_(false), port_set_(false), net_set_(false), is_scalar_(false), error_cnt_(0), uarray_type_(0), set_data_type_(0), discipline_(0) { - if (t == NetNet::INTEGER) { - type_ = NetNet::REG; - signed_ = true; - isint_ = true; - } } NetNet::Type PWire::get_wire_type() const @@ -64,18 +59,9 @@ bool PWire::set_wire_type(NetNet::Type t) type_ = t; return true; } - if (t == NetNet::INTEGER) { - type_ = NetNet::REG; - isint_ = true; - return true; - } if (t == NetNet::IMPLICIT_REG) return true; return false; case NetNet::REG: - if (t == NetNet::INTEGER) { - isint_ = true; - return true; - } if (t == NetNet::REG) return true; return false; default: @@ -146,18 +132,6 @@ bool PWire::get_signed() const return signed_; } -bool PWire::get_isint() const -{ - if (isint_) - return true; - - if (vector_type_t*tmp = dynamic_cast(set_data_type_)) { - return tmp->integer_flag; - } - - return false; -} - void PWire::set_range_scalar(PWSRType type) { is_scalar_ = true; @@ -267,11 +241,6 @@ void PWire::set_data_type(data_type_t*type) { assert(set_data_type_ == 0 || set_data_type_ == type); set_data_type_ = type; - - if (vector_type_t*tmp = dynamic_cast(type)) { - if (tmp->integer_flag) - isint_ = true; - } } void PWire::set_discipline(ivl_discipline_t d) @@ -289,7 +258,6 @@ PNamedItem::SymbolType PWire::symbol_type() const { switch (type_) { case NetNet::IMPLICIT_REG: - case NetNet::INTEGER: case NetNet::REG: return VAR; default: diff --git a/PWire.h b/PWire.h index dbf27dffd..dfc70970d 100644 --- a/PWire.h +++ b/PWire.h @@ -70,7 +70,6 @@ class PWire : public PNamedItem { void set_signed(bool flag); bool get_signed() const; - bool get_isint() const; bool set_data_type(ivl_variable_type_t dt); ivl_variable_type_t get_data_type() const; @@ -101,7 +100,6 @@ class PWire : public PNamedItem { NetNet::PortType port_type_; ivl_variable_type_t data_type_; bool signed_; - bool isint_; // original type of integer // These members hold expressions for the bit width of the // wire. If they do not exist, the wire is 1 bit wide. If they diff --git a/elab_sig.cc b/elab_sig.cc index 646da858d..7cb636ac3 100644 --- a/elab_sig.cc +++ b/elab_sig.cc @@ -942,7 +942,7 @@ ivl_type_t PWire::elaborate_type(Design*des, NetScope*scope, dynamic_cast(set_data_type_) || dynamic_cast(set_data_type_) || dynamic_cast(set_data_type_) || - dynamic_cast(set_data_type_)) { + dynamic_cast(set_data_type_)) { ivl_type_t use_type = set_data_type_->elaborate_type(des, scope); ivl_assert(*this, packed_dimensions.empty()); return use_type; @@ -967,7 +967,6 @@ ivl_type_t PWire::elaborate_type(Design*des, NetScope*scope, netvector_t*vec = new netvector_t(packed_dimensions, use_data_type); vec->set_signed(get_signed()); - vec->set_isint(get_isint()); return vec; } diff --git a/elab_type.cc b/elab_type.cc index ecd81e098..b77138ac3 100644 --- a/elab_type.cc +++ b/elab_type.cc @@ -66,28 +66,37 @@ ivl_type_t data_type_t::elaborate_type_raw(Design*des, NetScope*) const return 0; } -ivl_type_t atom2_type_t::elaborate_type_raw(Design*des, NetScope*) const +ivl_type_t atom_type_t::elaborate_type_raw(Design*des, NetScope*) const { switch (type_code) { - case 64: + case INTEGER: + return netvector_t::integer_type(signed_flag); + + case TIME: + if (signed_flag) + return &netvector_t::time_signed; + else + return &netvector_t::time_unsigned; + + case LONGINT: if (signed_flag) return &netvector_t::atom2s64; else return &netvector_t::atom2u64; - case 32: + case INT: if (signed_flag) return &netvector_t::atom2s32; else return &netvector_t::atom2u32; - case 16: + case SHORTINT: if (signed_flag) return &netvector_t::atom2s16; else return &netvector_t::atom2u16; - case 8: + case BYTE: if (signed_flag) return &netvector_t::atom2s8; else @@ -95,7 +104,7 @@ ivl_type_t atom2_type_t::elaborate_type_raw(Design*des, NetScope*) const default: cerr << get_fileline() << ": internal error: " - << "atom2_type_t type_code=" << type_code << "." << endl; + << "atom_type_t type_code=" << type_code << "." << endl; des->errors += 1; return 0; } diff --git a/link_const.cc b/link_const.cc index 447c789c8..5887a4aa9 100644 --- a/link_const.cc +++ b/link_const.cc @@ -293,7 +293,7 @@ vector Nexus::driven_mask(void) const // information from this node, move on. if (const NetNet*sig = dynamic_cast (obj)) { NetNet::Type sig_type = sig->type(); - if (sig_type==NetNet::INTEGER || sig_type==NetNet::REG) { + if (sig_type==NetNet::REG) { for (size_t idx = 0 ; idx < mask.size() ; idx += 1) mask[idx] = true; return mask; diff --git a/netlist.cc b/netlist.cc index 7b23b782b..a4b05c413 100644 --- a/netlist.cc +++ b/netlist.cc @@ -51,9 +51,6 @@ ostream& operator<< (ostream&o, NetNet::Type t) case NetNet::IMPLICIT_REG: o << "reg /*implicit*/"; break; - case NetNet::INTEGER: - o << "integer"; - break; case NetNet::REG: o << "reg"; break; diff --git a/netlist.h b/netlist.h index ff7cf133d..093a05338 100644 --- a/netlist.h +++ b/netlist.h @@ -664,7 +664,7 @@ struct PortInfo class NetNet : public NetObj, public PortType { public: - enum Type ENUM_UNSIGNED_INT { NONE, IMPLICIT, IMPLICIT_REG, INTEGER, WIRE, TRI, TRI1, + enum Type ENUM_UNSIGNED_INT { NONE, IMPLICIT, IMPLICIT_REG, WIRE, TRI, TRI1, SUPPLY0, SUPPLY1, WAND, TRIAND, TRI0, WOR, TRIOR, REG, UNRESOLVED_WIRE }; diff --git a/netvector.cc b/netvector.cc index 4d235eb22..86f3d1637 100644 --- a/netvector.cc +++ b/netvector.cc @@ -32,15 +32,18 @@ netvector_t netvector_t::atom2u16 (IVL_VT_BOOL, 15, 0, false); netvector_t netvector_t::atom2s8 (IVL_VT_BOOL, 7, 0, true); netvector_t netvector_t::atom2u8 (IVL_VT_BOOL, 7, 0, false); -static netvector_t* save_integer_type = 0; -const netvector_t* netvector_t::integer_type() -{ - if (save_integer_type) - return save_integer_type; +netvector_t netvector_t::time_signed (IVL_VT_LOGIC, 63, 0, true); +netvector_t netvector_t::time_unsigned (IVL_VT_LOGIC, 63, 0, false); - save_integer_type = new netvector_t(IVL_VT_LOGIC, integer_width-1, 0, true); - save_integer_type->set_isint(true); - return save_integer_type; +static netvector_t* save_integer_type[2]; +const netvector_t* netvector_t::integer_type(bool is_signed) +{ + if (save_integer_type[is_signed]) + return save_integer_type[is_signed]; + + save_integer_type[is_signed] = new netvector_t(IVL_VT_LOGIC, integer_width-1, 0, is_signed); + save_integer_type[is_signed]->set_isint(true); + return save_integer_type[is_signed]; } //netvector_t netvector_t::scalar_bool (IVL_VT_BOOL); diff --git a/netvector.h b/netvector.h index 2775a718d..c79672900 100644 --- a/netvector.h +++ b/netvector.h @@ -75,9 +75,11 @@ class netvector_t : public ivl_type_s { static netvector_t atom2u16; static netvector_t atom2s8; static netvector_t atom2u8; + static netvector_t time_signed; + static netvector_t time_unsigned; static netvector_t scalar_bool; static netvector_t scalar_logic; - static const netvector_t*integer_type(); + static const netvector_t*integer_type(bool is_signed = true); private: bool test_compatibility(ivl_type_t that) const; diff --git a/parse.y b/parse.y index 1e802d8a4..a7190d63a 100644 --- a/parse.y +++ b/parse.y @@ -380,6 +380,8 @@ static void current_function_set_statement(const YYLTYPE&loc, std::vector non_integer_type %type assert_or_assume %type deferred_mode -%type atom2_type +%type atom_type %type module_start module_end %type lifetime lifetime_opt @@ -1224,20 +1226,14 @@ simple_packed_type /* Integer and vector types */ FILE_NAME(tmp, @1); $$ = tmp; } - | atom2_type signed_unsigned_opt - { atom2_type_t*tmp = new atom2_type_t($1, $2); + | atom_type signed_unsigned_opt + { atom_type_t*tmp = new atom_type_t($1, $2); FILE_NAME(tmp, @1); $$ = tmp; } - | K_integer signed_unsigned_opt - { std::list*pd = make_range_from_width(integer_width); - vector_type_t*tmp = new vector_type_t(IVL_VT_LOGIC, $2, pd); - tmp->integer_flag = true; - $$ = tmp; - } | K_time unsigned_signed_opt - { std::list*pd = make_range_from_width(64); - vector_type_t*tmp = new vector_type_t(IVL_VT_LOGIC, $2, pd); + { atom_type_t*tmp = new atom_type_t(atom_type_t::TIME, $2); + FILE_NAME(tmp, @1); $$ = tmp; } ; @@ -2184,20 +2180,14 @@ simple_type_or_string /* IEEE1800-2005: A.2.2.1 */ FILE_NAME(tmp, @1); $$ = tmp; } - | atom2_type - { atom2_type_t*tmp = new atom2_type_t($1, true); + | atom_type + { atom_type_t*tmp = new atom_type_t($1, true); FILE_NAME(tmp, @1); $$ = tmp; } - | K_integer - { std::list*pd = make_range_from_width(integer_width); - vector_type_t*tmp = new vector_type_t(IVL_VT_LOGIC, true, pd); - tmp->integer_flag = true; - $$ = tmp; - } | K_time - { std::list*pd = make_range_from_width(64); - vector_type_t*tmp = new vector_type_t(IVL_VT_LOGIC, false, pd); + { atom_type_t*tmp = new atom_type_t(atom_type_t::TIME, false); + FILE_NAME(tmp, @1); $$ = tmp; } | K_string @@ -2750,7 +2740,7 @@ enum_base_type /* IEEE 1800-2012 A.2.2.1 */ } } | - { $$ = new atom2_type_t(32, true); + { $$ = new atom_type_t(atom_type_t::INT, true); FILE_NAME($$, @0); } ; @@ -4604,11 +4594,12 @@ signed_unsigned_opt * In some places we can take any of the 4 2-value atom-type * names. All the context needs to know if that type is its width. */ -atom2_type - : K_byte { $$ = 8; } - | K_shortint { $$ = 16; } - | K_int { $$ = 32; } - | K_longint { $$ = 64; } +atom_type + : K_byte { $$ = atom_type_t::BYTE; } + | K_shortint { $$ = atom_type_t::SHORTINT; } + | K_int { $$ = atom_type_t::INT; } + | K_longint { $$ = atom_type_t::LONGINT; } + | K_integer { $$ = atom_type_t::INTEGER; } ; /* An lpvalue is the expression that can go on the left side of a diff --git a/pform.cc b/pform.cc index fcd639a93..0fd56df41 100644 --- a/pform.cc +++ b/pform.cc @@ -2862,8 +2862,7 @@ static vector*pform_make_task_ports(const struct vlltype&loc, ivl_variable_type_t vtype, bool signed_flag, list*range, - list*ports, - bool isint = false) + list*ports) { assert(pt != NetNet::PIMPLICIT && pt != NetNet::NOT_A_PORT); assert(ports); @@ -2884,10 +2883,6 @@ static vector*pform_make_task_ports(const struct vlltype&loc, } curw->set_signed(signed_flag); - if (isint) { - bool flag = curw->set_wire_type(NetNet::INTEGER); - assert(flag); - } /* If there is a range involved, it needs to be set. */ if (range) { @@ -2954,8 +2949,9 @@ vector*pform_make_task_ports(const struct vlltype&loc, vtype = uarray->base_type; } - if (dynamic_cast (vtype)) { - ret = do_make_task_ports(loc, pt, IVL_VT_BOOL, vtype, ports); + if (dynamic_cast (vtype)) { + ret = do_make_task_ports(loc, pt, vtype->figure_packed_base_type(), + vtype, ports); } if (vector_type_t*vec_type = dynamic_cast (vtype)) { @@ -2966,7 +2962,7 @@ vector*pform_make_task_ports(const struct vlltype&loc, ret = pform_make_task_ports(loc, pt, base_type, vec_type->signed_flag, copy_range(vec_type->pdims.get()), - ports, vec_type->integer_flag); + ports); } if (/*real_type_t*real_type = */ dynamic_cast (vtype)) { @@ -3440,9 +3436,6 @@ void pform_set_data_type(const struct vlltype&li, data_type_t*data_type, listbase_type; if (vector_type_t*vec_type = dynamic_cast (data_type)) { - if (net_type==NetNet::REG && vec_type->integer_flag) - net_type=NetNet::INTEGER; - pform_set_net_range(names, vec_type->pdims.get(), vec_type->signed_flag, 0); vt = vec_type->base_type; diff --git a/pform_dump.cc b/pform_dump.cc index 0c0874d00..38c1675cc 100644 --- a/pform_dump.cc +++ b/pform_dump.cc @@ -173,13 +173,36 @@ ostream& data_type_t::debug_dump(ostream&out) const return out; } -ostream& atom2_type_t::debug_dump(ostream&out) const +ostream& atom_type_t::debug_dump(ostream&out) const { if (signed_flag) - out << "signed-"; + out << "signed "; else - out << "unsigned-"; - out << "int(" << type_code << ")"; + out << "unsigned "; + + switch (type_code) { + case INTEGER: + out << "integer"; + break; + case TIME: + out << "time"; + break; + case LONGINT: + out << "longint"; + break; + case INT: + out << "int"; + break; + case SHORTINT: + out << "shortint"; + break; + case BYTE: + out << "byte"; + break; + default: + assert(0); + break; + } return out; } @@ -584,9 +607,6 @@ void PWire::dump(ostream&out, unsigned ind) const if (signed_) { out << " signed"; } - if (get_isint()) { - out << " integer"; - } if (is_scalar_) { out << " scalar"; } diff --git a/pform_types.cc b/pform_types.cc index 28dfe15fc..7df2ccbc2 100644 --- a/pform_types.cc +++ b/pform_types.cc @@ -53,12 +53,18 @@ ivl_variable_type_t enum_type_t::figure_packed_base_type() const return base_type->figure_packed_base_type(); } -ivl_variable_type_t atom2_type_t::figure_packed_base_type() const +ivl_variable_type_t atom_type_t::figure_packed_base_type() const { - return IVL_VT_BOOL; + switch (type_code) { + case TIME: + case INT: + return IVL_VT_LOGIC; + default: + return IVL_VT_BOOL; + } } -atom2_type_t size_type (32, true); +atom_type_t size_type (atom_type_t::INT, true); PNamedItem::SymbolType enum_type_t::symbol_type() const { diff --git a/pform_types.h b/pform_types.h index b32f674bd..dc4bb8da4 100644 --- a/pform_types.h +++ b/pform_types.h @@ -208,10 +208,20 @@ struct struct_type_t : public data_type_t { std::unique_ptr< std::list > members; }; -struct atom2_type_t : public data_type_t { - inline explicit atom2_type_t(int tc, bool flag) - : type_code(tc), signed_flag(flag) { } - int type_code; +struct atom_type_t : public data_type_t { + enum type_code { + INTEGER, + TIME, + BYTE, + SHORTINT, + INT, + LONGINT + }; + + explicit atom_type_t(enum type_code tc, bool flag) : type_code(tc), + signed_flag(flag) { } + + enum type_code type_code; bool signed_flag; virtual std::ostream& debug_dump(std::ostream&out) const; @@ -221,7 +231,7 @@ struct atom2_type_t : public data_type_t { ivl_variable_type_t figure_packed_base_type() const; }; -extern atom2_type_t size_type; +extern atom_type_t size_type; /* * The vector_type_t class represents types in the old Verilog