From ea938b7907bd5c2f2f94ec06e38710d3ee30abfc Mon Sep 17 00:00:00 2001 From: Stephen Williams Date: Thu, 1 Jan 2009 08:33:26 -0800 Subject: [PATCH] Revert "Enable -Wshadow by default" This reverts commit 31d67fcd3eb17a2897702250badb776ff3053af7. The concensus has been that this causes too many build problems in the general case and what is needed instead is a way to turn on the extra warnings for developers only. --- Makefile.in | 2 +- cadpli/Makefile.in | 2 +- driver-vpi/Makefile.in | 2 +- driver/Makefile.in | 2 +- ivlpp/Makefile.in | 2 +- libveriuser/Makefile.in | 2 +- tgt-fpga/Makefile.in | 2 +- tgt-null/Makefile.in | 2 +- tgt-pal/Makefile.in | 2 +- tgt-stub/Makefile.in | 2 +- tgt-verilog/Makefile.in | 2 +- tgt-vhdl/Makefile.in | 2 +- tgt-vvp/Makefile.in | 2 +- vpi/Makefile.in | 2 +- vvp/Makefile.in | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Makefile.in b/Makefile.in index 50b6de0db..2a6778862 100644 --- a/Makefile.in +++ b/Makefile.in @@ -81,7 +81,7 @@ PS2PDF = @PS2PDF@ GIT = @GIT@ CPPFLAGS = @DEFS@ -I. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ -CXXFLAGS = -Wall -Wshadow @CXXFLAGS@ +CXXFLAGS = -Wall @CXXFLAGS@ PICFLAGS = @PICFLAG@ LDFLAGS = @rdynamic@ @LDFLAGS@ diff --git a/cadpli/Makefile.in b/cadpli/Makefile.in index 4677892cc..f8db775d4 100644 --- a/cadpli/Makefile.in +++ b/cadpli/Makefile.in @@ -40,7 +40,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I$(srcdir) -I$(srcdir)/.. -I.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ SHARED = @shared@ diff --git a/driver-vpi/Makefile.in b/driver-vpi/Makefile.in index 9c14aef4b..4ebecf251 100644 --- a/driver-vpi/Makefile.in +++ b/driver-vpi/Makefile.in @@ -44,7 +44,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: iverilog-vpi@EXEEXT@ diff --git a/driver/Makefile.in b/driver/Makefile.in index a8f4623bc..06120c05b 100644 --- a/driver/Makefile.in +++ b/driver/Makefile.in @@ -44,7 +44,7 @@ MAN = @MAN@ PS2PDF = @PS2PDF@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep iverilog@EXEEXT@ diff --git a/ivlpp/Makefile.in b/ivlpp/Makefile.in index 575680ea2..6de9d85da 100644 --- a/ivlpp/Makefile.in +++ b/ivlpp/Makefile.in @@ -40,7 +40,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: ivlpp@EXEEXT@ diff --git a/libveriuser/Makefile.in b/libveriuser/Makefile.in index 0afaf2595..066aa5a57 100644 --- a/libveriuser/Makefile.in +++ b/libveriuser/Makefile.in @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir) -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ RANLIB = @RANLIB@ diff --git a/tgt-fpga/Makefile.in b/tgt-fpga/Makefile.in index 06067835c..7d3344507 100644 --- a/tgt-fpga/Makefile.in +++ b/tgt-fpga/Makefile.in @@ -41,7 +41,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I.. -I$(srcdir) -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep fpga.tgt diff --git a/tgt-null/Makefile.in b/tgt-null/Makefile.in index e9a58e3c4..164a18f13 100644 --- a/tgt-null/Makefile.in +++ b/tgt-null/Makefile.in @@ -37,7 +37,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep null.tgt diff --git a/tgt-pal/Makefile.in b/tgt-pal/Makefile.in index 2db8fc8b0..112a02b65 100644 --- a/tgt-pal/Makefile.in +++ b/tgt-pal/Makefile.in @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep pal.tgt diff --git a/tgt-stub/Makefile.in b/tgt-stub/Makefile.in index 24e2f4635..2b474e1b1 100644 --- a/tgt-stub/Makefile.in +++ b/tgt-stub/Makefile.in @@ -38,7 +38,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep stub.tgt diff --git a/tgt-verilog/Makefile.in b/tgt-verilog/Makefile.in index 884ebcd4c..875972a1a 100644 --- a/tgt-verilog/Makefile.in +++ b/tgt-verilog/Makefile.in @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = @ident_support@ -I.. -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep verilog.tgt diff --git a/tgt-vhdl/Makefile.in b/tgt-vhdl/Makefile.in index 6ce1d046f..2fdeb3afe 100644 --- a/tgt-vhdl/Makefile.in +++ b/tgt-vhdl/Makefile.in @@ -39,7 +39,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CXXFLAGS = -Wall -Wshadow @CXXFLAGS@ +CXXFLAGS = -Wall @CXXFLAGS@ LDFLAGS = @LDFLAGS@ all: dep vhdl.tgt vhdl.conf vhdl-s.conf diff --git a/tgt-vvp/Makefile.in b/tgt-vvp/Makefile.in index 0a40aa275..3bb5f3d95 100644 --- a/tgt-vvp/Makefile.in +++ b/tgt-vvp/Makefile.in @@ -41,7 +41,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep vvp.tgt vvp.conf vvp-s.conf diff --git a/vpi/Makefile.in b/vpi/Makefile.in index 248fd4b66..8993de1d0 100644 --- a/vpi/Makefile.in +++ b/vpi/Makefile.in @@ -42,7 +42,7 @@ LEX = @LEX@ YACC = @YACC@ CPPFLAGS = -I. -I$(srcdir)/.. -I$(srcdir) -I.. @file64_support@ @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall -Wshadow @CFLAGS@ +CFLAGS = -Wall @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep system.vpi va_math.vpi v2005_math.vpi $(ALL32) diff --git a/vvp/Makefile.in b/vvp/Makefile.in index 5b674617d..efffd61a9 100644 --- a/vvp/Makefile.in +++ b/vvp/Makefile.in @@ -48,7 +48,7 @@ MAN = @MAN@ PS2PDF = @PS2PDF@ CPPFLAGS = -I. -I.. -I $(srcdir) -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CXXFLAGS = -Wall -Wshadow @CXXFLAGS@ +CXXFLAGS = -Wall @CXXFLAGS@ LDFLAGS = @rdynamic@ @LDFLAGS@ LIBS = @LIBS@ @EXTRALIBS@