From 9da5c1868f7e157917315220809a53683a9f5690 Mon Sep 17 00:00:00 2001 From: Cary R Date: Fri, 6 Feb 2026 15:03:58 -0800 Subject: [PATCH] New cppcheck cleanup --- cppcheck.sup | 1 - driver/cppcheck.sup | 3 --- tgt-pcb/cppcheck.sup | 4 ---- vhdlpp/cppcheck.sup | 3 --- vpi/cppcheck.sup | 2 +- vvp/cppcheck.sup | 14 +------------- vvp/vvp_net.cc | 2 +- 7 files changed, 3 insertions(+), 26 deletions(-) diff --git a/cppcheck.sup b/cppcheck.sup index db414c378..964705c9c 100644 --- a/cppcheck.sup +++ b/cppcheck.sup @@ -761,7 +761,6 @@ allocaCalled:parse.cc constParameterPointer:parse.cc constVariablePointer:parse.cc knownConditionTrueFalse:parse.cc -syntaxError:parse.cc allocaCalled:syn-rules.cc constParameterPointer:syn-rules.cc knownConditionTrueFalse:syn-rules.cc diff --git a/driver/cppcheck.sup b/driver/cppcheck.sup index 501a3a99f..f33c05c09 100644 --- a/driver/cppcheck.sup +++ b/driver/cppcheck.sup @@ -18,11 +18,8 @@ memleakOnRealloc:cfparse.y allocaCalled:cfparse.c constParameterPointer:cfparse.c constVariablePointer:cfparse.c -invalidPrintfArgType_sint:cfparse.c knownConditionTrueFalse:cfparse.c sizeofwithnumericparameter:cfparse.c -syntaxError:cfparse.c -unsignedPositive:cfparse.c constVariablePointer: nullPointer: redundantInitialization: diff --git a/tgt-pcb/cppcheck.sup b/tgt-pcb/cppcheck.sup index 16094125f..789847374 100644 --- a/tgt-pcb/cppcheck.sup +++ b/tgt-pcb/cppcheck.sup @@ -10,14 +10,10 @@ unusedFunction:pcb.cc:84 // Errors/limitations in the generated yacc and lex files duplicateBreak:fp.lex constParameterPointer:fp.cc -invalidPrintfArgType_sint:fp.cc knownConditionTrueFalse:fp.cc -syntaxError:fp.cc -unsignedPositive:fp.cc constVariablePointer:fp_lex.cc cstyleCast:fp_lex.cc nullPointer:fp_lex.cc redundantInitialization:fp_lex.cc -syntaxError:fp_lex.cc unusedFunction:fp_lex.cc unusedStructMember:fp_lex.cc diff --git a/vhdlpp/cppcheck.sup b/vhdlpp/cppcheck.sup index 1c77ec794..b64b5963f 100644 --- a/vhdlpp/cppcheck.sup +++ b/vhdlpp/cppcheck.sup @@ -29,10 +29,7 @@ duplicateBreak:lexor.lex redundantInitialization:lexor.lex uselessAssignmentPtrArg:lexor.lex constParameterPointer:parse.cc -invalidPrintfArgType_sint:parse.cc knownConditionTrueFalse:parse.cc -syntaxError:parse.cc -unsignedPositive:parse.cc // Unused functions unusedFunction:LineInfo.h diff --git a/vpi/cppcheck.sup b/vpi/cppcheck.sup index ddb1d42d6..42a76aabd 100644 --- a/vpi/cppcheck.sup +++ b/vpi/cppcheck.sup @@ -38,7 +38,7 @@ constParameterCallback:sys_convert.c:150 constParameterCallback:sys_display.c:1281 constParameterCallback:sys_display.c:1379 constParameterCallback:sys_display.c:1553 -constParameterCallback:sys_display.c:2169 +constParameterCallback:sys_display.c:2174 constParameterCallback:sys_fileio.c:261 constParameterCallback:sys_random.c:497 constParameterCallback:sys_sdf.c:437 diff --git a/vvp/cppcheck.sup b/vvp/cppcheck.sup index ae12855a5..c78173dc6 100644 --- a/vvp/cppcheck.sup +++ b/vvp/cppcheck.sup @@ -10,7 +10,7 @@ nullPointerOutOfMemory //constVariablePointer:main.cc:400 // Only for conditional debugging -knownConditionTrueFalse:lib_main.cc:289 +knownConditionTrueFalse:lib_main.cc:282 // For now these casts have to be used dangerousTypeCast:array_common.cc:188 @@ -207,18 +207,6 @@ unusedFunction:vpi_priv.cc:1904 // vpi_vprintf() unusedFunction:vpi_priv.cc:1505 -// The following are used in the embedded version of iverilog. -// vvp_init() -unusedFunction:lib_main.cc:275 -// vvp_run() -unusedFunction:lib_main.cc:339 -// vvp_set_quiet_flag() -unusedFunction:lib_main.cc:71 -// vvp_set_stop_is_finish() -unusedFunction:lib_main.cc:62 -// vvp_set_verbose_flag() -unusedFunction:lib_main.cc:76 - // The following are just unused. // alias_word() unusedFunction:array.cc:848 diff --git a/vvp/vvp_net.cc b/vvp/vvp_net.cc index bf1ed7e8d..ee1e123a1 100644 --- a/vvp/vvp_net.cc +++ b/vvp/vvp_net.cc @@ -2146,7 +2146,7 @@ bool vector2_to_value(const vvp_vector2_t&a, int32_t&val, bool is_signed) { val = 0; unsigned idx; - int32_t mask; + uint32_t mask; for (idx = 0, mask = 1 ; idx < a.size() && idx < 32 ; idx += 1, mask <<= 1) { if (a.value(idx)) val |= mask; }