From 31d67fcd3eb17a2897702250badb776ff3053af7 Mon Sep 17 00:00:00 2001 From: Larry Doolittle Date: Mon, 22 Dec 2008 08:33:28 -0800 Subject: [PATCH] Enable -Wshadow by default The code base is almost shadow-free now, so this won't add much noise to the compiles. Problems I know about: lxt{,2}_write.c: patch sent upstream cflexor.c: exposes gray area of name space boundary --- Makefile.in | 2 +- cadpli/Makefile.in | 2 +- driver-vpi/Makefile.in | 2 +- driver/Makefile.in | 2 +- ivlpp/Makefile.in | 2 +- libveriuser/Makefile.in | 2 +- tgt-fpga/Makefile.in | 2 +- tgt-null/Makefile.in | 2 +- tgt-pal/Makefile.in | 2 +- tgt-stub/Makefile.in | 2 +- tgt-verilog/Makefile.in | 2 +- tgt-vhdl/Makefile.in | 2 +- tgt-vvp/Makefile.in | 2 +- vpi/Makefile.in | 2 +- vvp/Makefile.in | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Makefile.in b/Makefile.in index 2a6778862..50b6de0db 100644 --- a/Makefile.in +++ b/Makefile.in @@ -81,7 +81,7 @@ PS2PDF = @PS2PDF@ GIT = @GIT@ CPPFLAGS = @DEFS@ -I. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ -CXXFLAGS = -Wall @CXXFLAGS@ +CXXFLAGS = -Wall -Wshadow @CXXFLAGS@ PICFLAGS = @PICFLAG@ LDFLAGS = @rdynamic@ @LDFLAGS@ diff --git a/cadpli/Makefile.in b/cadpli/Makefile.in index f8db775d4..4677892cc 100644 --- a/cadpli/Makefile.in +++ b/cadpli/Makefile.in @@ -40,7 +40,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I$(srcdir) -I$(srcdir)/.. -I.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ SHARED = @shared@ diff --git a/driver-vpi/Makefile.in b/driver-vpi/Makefile.in index 29f25bc70..d91cb876c 100644 --- a/driver-vpi/Makefile.in +++ b/driver-vpi/Makefile.in @@ -44,7 +44,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: iverilog-vpi@EXEEXT@ diff --git a/driver/Makefile.in b/driver/Makefile.in index 06120c05b..a8f4623bc 100644 --- a/driver/Makefile.in +++ b/driver/Makefile.in @@ -44,7 +44,7 @@ MAN = @MAN@ PS2PDF = @PS2PDF@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep iverilog@EXEEXT@ diff --git a/ivlpp/Makefile.in b/ivlpp/Makefile.in index 6de9d85da..575680ea2 100644 --- a/ivlpp/Makefile.in +++ b/ivlpp/Makefile.in @@ -40,7 +40,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: ivlpp@EXEEXT@ diff --git a/libveriuser/Makefile.in b/libveriuser/Makefile.in index 066aa5a57..0afaf2595 100644 --- a/libveriuser/Makefile.in +++ b/libveriuser/Makefile.in @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir) -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ RANLIB = @RANLIB@ diff --git a/tgt-fpga/Makefile.in b/tgt-fpga/Makefile.in index 7d3344507..06067835c 100644 --- a/tgt-fpga/Makefile.in +++ b/tgt-fpga/Makefile.in @@ -41,7 +41,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I.. -I$(srcdir) -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep fpga.tgt diff --git a/tgt-null/Makefile.in b/tgt-null/Makefile.in index 164a18f13..e9a58e3c4 100644 --- a/tgt-null/Makefile.in +++ b/tgt-null/Makefile.in @@ -37,7 +37,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I.. -I$(srcdir)/.. -I$(srcdir) -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep null.tgt diff --git a/tgt-pal/Makefile.in b/tgt-pal/Makefile.in index 112a02b65..2db8fc8b0 100644 --- a/tgt-pal/Makefile.in +++ b/tgt-pal/Makefile.in @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep pal.tgt diff --git a/tgt-stub/Makefile.in b/tgt-stub/Makefile.in index 2b474e1b1..24e2f4635 100644 --- a/tgt-stub/Makefile.in +++ b/tgt-stub/Makefile.in @@ -38,7 +38,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep stub.tgt diff --git a/tgt-verilog/Makefile.in b/tgt-verilog/Makefile.in index 875972a1a..884ebcd4c 100644 --- a/tgt-verilog/Makefile.in +++ b/tgt-verilog/Makefile.in @@ -36,7 +36,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = @ident_support@ -I.. -I$(srcdir)/.. @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep verilog.tgt diff --git a/tgt-vhdl/Makefile.in b/tgt-vhdl/Makefile.in index 2fdeb3afe..6ce1d046f 100644 --- a/tgt-vhdl/Makefile.in +++ b/tgt-vhdl/Makefile.in @@ -39,7 +39,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CXXFLAGS = -Wall @CXXFLAGS@ +CXXFLAGS = -Wall -Wshadow @CXXFLAGS@ LDFLAGS = @LDFLAGS@ all: dep vhdl.tgt vhdl.conf vhdl-s.conf diff --git a/tgt-vvp/Makefile.in b/tgt-vvp/Makefile.in index 3bb5f3d95..0a40aa275 100644 --- a/tgt-vvp/Makefile.in +++ b/tgt-vvp/Makefile.in @@ -41,7 +41,7 @@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ CPPFLAGS = -I. -I.. -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep vvp.tgt vvp.conf vvp-s.conf diff --git a/vpi/Makefile.in b/vpi/Makefile.in index 8993de1d0..248fd4b66 100644 --- a/vpi/Makefile.in +++ b/vpi/Makefile.in @@ -42,7 +42,7 @@ LEX = @LEX@ YACC = @YACC@ CPPFLAGS = -I. -I$(srcdir)/.. -I$(srcdir) -I.. @file64_support@ @CPPFLAGS@ @DEFS@ @PICFLAG@ -CFLAGS = -Wall @CFLAGS@ +CFLAGS = -Wall -Wshadow @CFLAGS@ LDFLAGS = @LDFLAGS@ all: dep system.vpi va_math.vpi v2005_math.vpi $(ALL32) diff --git a/vvp/Makefile.in b/vvp/Makefile.in index efffd61a9..5b674617d 100644 --- a/vvp/Makefile.in +++ b/vvp/Makefile.in @@ -48,7 +48,7 @@ MAN = @MAN@ PS2PDF = @PS2PDF@ CPPFLAGS = -I. -I.. -I $(srcdir) -I$(srcdir)/.. -DVERSION='"$(VERSION)"' @CPPFLAGS@ @DEFS@ -CXXFLAGS = -Wall @CXXFLAGS@ +CXXFLAGS = -Wall -Wshadow @CXXFLAGS@ LDFLAGS = @rdynamic@ @LDFLAGS@ LIBS = @LIBS@ @EXTRALIBS@