From e96358dc3bb40643b1820b213115a55a8edbe1ee Mon Sep 17 00:00:00 2001 From: Christoph Weiss Date: Thu, 20 Mar 2025 17:28:30 +0100 Subject: [PATCH] Remove harmful dtor definition The definition of the dtor is not necessary and actually harmful since the definition of a class's implicit copy constructor is deprecated if that class has a user-declared constructor as of C++11. Compilers can warn about this with `-Wdeprecated`. --- include/cxxopts.hpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/cxxopts.hpp b/include/cxxopts.hpp index 1e16274..87d0701 100644 --- a/include/cxxopts.hpp +++ b/include/cxxopts.hpp @@ -1302,8 +1302,6 @@ template <> class standard_value : public abstract_value { public: - ~standard_value() override = default; - standard_value() { set_default_and_implicit();