From 687314a05533002ee0b480c2452b5455400cd3a3 Mon Sep 17 00:00:00 2001 From: Matt Liberty Date: Mon, 6 Apr 2026 00:50:06 +0000 Subject: [PATCH 1/2] Add GHA to check for differences found in .ok files Same as in OR Signed-off-by: Matt Liberty --- .../github-actions-are-differences-found.yml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/github-actions-are-differences-found.yml diff --git a/.github/workflows/github-actions-are-differences-found.yml b/.github/workflows/github-actions-are-differences-found.yml new file mode 100644 index 00000000..45436800 --- /dev/null +++ b/.github/workflows/github-actions-are-differences-found.yml @@ -0,0 +1,20 @@ +name: Check that OK files are up to date + +on: + pull_request: + +jobs: + No-Diffs-In-Ok-Files: + runs-on: ${{ vars.USE_SELF_HOSTED == 'true' && 'self-hosted' || 'ubuntu-latest' }} + steps: + - name: Check out repository code + uses: actions/checkout@v6 + with: + fetch-depth: 0 + - name: Check ok files + run: | + set +e + grep --include="*.ok" -Rn "Differences found " + if [[ "$?" == "0" ]]; then + exit 1 + fi From d1bc00cf8c6ea1e17078288720fc5d9fe41fab4c Mon Sep 17 00:00:00 2001 From: Matt Liberty Date: Mon, 6 Apr 2026 04:55:41 +0000 Subject: [PATCH 2/2] update tests to avoid "Differences found" in .ok files Signed-off-by: Matt Liberty --- util/test/util_log_redirect.ok | 2 +- util/test/util_log_redirect.tcl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/util/test/util_log_redirect.ok b/util/test/util_log_redirect.ok index baa82e6a..6d2ed512 100644 --- a/util/test/util_log_redirect.ok +++ b/util/test/util_log_redirect.ok @@ -64,7 +64,6 @@ Path Type: min No paths found. -Warning 168: util_log_redirect.tcl line 1, unknown field nets. Startpoint: r3 (rising edge-triggered flip-flop clocked by clk) Endpoint: out (output port clocked by clk) Path Group: clk @@ -76,6 +75,7 @@ Fanout Cap Slew Delay Time Description 0.00 0.00 clock network delay (ideal) 0.00 0.00 0.00 ^ r3/CLK (DFFHQx4_ASAP7_75t_R) 1 0.00 0.01 0.04 0.04 ^ r3/Q (DFFHQx4_ASAP7_75t_R) + out (net) 0.00 0.00 0.04 ^ out (out) 0.04 data arrival time diff --git a/util/test/util_log_redirect.tcl b/util/test/util_log_redirect.tcl index df6fa2e4..45dc9e20 100644 --- a/util/test/util_log_redirect.tcl +++ b/util/test/util_log_redirect.tcl @@ -30,7 +30,7 @@ log_begin $log_file1 report_checks report_checks -path_delay min report_checks -from [get_ports in1] -to [get_ports out] -report_checks -fields {slew cap input_pins nets fanout} +report_checks -fields {slew cap input_pins net fanout} report_units log_end