From 5fd751e8d7b5c5f811846fc43b0de7f6ae60f4ee Mon Sep 17 00:00:00 2001 From: Jaehyun Kim Date: Tue, 7 Apr 2026 23:42:21 +0900 Subject: [PATCH] Revert diff_files/diff_files_sorted to original return behavior Revert error-on-mismatch back to return 1, as the new GitHub Action (github-actions-are-differences-found) now detects "Differences found" in CI output, making the error approach unnecessary. Co-Authored-By: Claude Signed-off-by: Jaehyun Kim --- test/helpers.tcl | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/test/helpers.tcl b/test/helpers.tcl index d2d4b60c..01dab3d7 100644 --- a/test/helpers.tcl +++ b/test/helpers.tcl @@ -56,10 +56,14 @@ proc diff_files_sorted { file1 file2 } { } else { for {set i 0} {$i < [llength $lines1] && $i < [llength $lines2]} {incr i} { if { [lindex $lines1 $i] ne [lindex $lines2 $i] } { - error "diff_files_sorted: $file1 vs $file2 differ at sorted line $i\n< [lindex $lines1 $i]\n> [lindex $lines2 $i]" + puts "Differences found (sorted)." + puts "[lindex $lines1 $i]" + puts "[lindex $lines2 $i]" + return 1 } } - error "diff_files_sorted: $file1 vs $file2 differ: file lengths differ" + puts "Differences found (sorted): file lengths differ." + return 1 } } @@ -102,7 +106,10 @@ proc diff_files { file1 file2 { ignore "" } } { close $stream1 close $stream2 if { $found_diff || $line1_length != $line2_length } { - error "diff_files: $file1 vs $file2 differ at line $line\n< $line1\n> $line2" + puts "Differences found at line $line." + puts "$line1" + puts "$line2" + return 1 } else { puts "No differences found." return 0