From dad8c74f752fa6b66d8bede2141b9f524afd3b24 Mon Sep 17 00:00:00 2001
From: James Cherry <cherry@parallaxsw.com>
Date: Wed, 4 Oct 2023 09:28:21 -0700
Subject: [PATCH] get_cells/get_lib_cells require pattern

Signed-off-by: James Cherry <cherry@parallaxsw.com>
---
 tcl/Sdc.tcl | 34 +++++++++++++++-------------------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/tcl/Sdc.tcl b/tcl/Sdc.tcl
index 4f5b97d5..c8b67729 100644
--- a/tcl/Sdc.tcl
+++ b/tcl/Sdc.tcl
@@ -454,7 +454,6 @@ proc get_cells { args } {
 
   parse_key_args "get_cells" args keys {-hsc -filter -of_objects} \
     flags {-hierarchical -regexp -nocase -quiet}
-  check_argc_eq0or1 "get_cells" $args
   check_nocase_flag flags
 
   set regexp [info exists flags(-regexp)]
@@ -493,23 +492,20 @@ proc get_cells { args } {
       $pin_iter finish
     }
   } else {
-    if { $args == {} } {
-      set insts [network_leaf_instances]
-    } else {
-      foreach pattern $patterns {
-	if { $divider != $hierarchy_separator } {
-	  regsub $divider $pattern $hierarchy_separator pattern
-	}
-	if { $hierarchical } {
-	  set matches [find_instances_hier_matching $pattern $regexp $nocase]
-	} else {
-	  set matches [find_instances_matching $pattern $regexp $nocase]
-	}
-	if { $matches == {} && !$quiet} {
-	  sta_warn 322 "instance '$pattern' not found."
-	}
-	set insts [concat $insts $matches]
+    check_argc_eq1 "get_cells" $args
+    foreach pattern $patterns {
+      if { $divider != $hierarchy_separator } {
+        regsub $divider $pattern $hierarchy_separator pattern
       }
+      if { $hierarchical } {
+        set matches [find_instances_hier_matching $pattern $regexp $nocase]
+      } else {
+        set matches [find_instances_matching $pattern $regexp $nocase]
+      }
+      if { $matches == {} && !$quiet} {
+        sta_warn 322 "instance '$pattern' not found."
+      }
+      set insts [concat $insts $matches]
     }
   }
   if [info exists keys(-filter)] {
@@ -586,7 +582,6 @@ proc get_lib_cells { args } {
   global hierarchy_separator
   parse_key_args "get_lib_cells" args keys {-hsc -of_objects} \
     flags {-regexp -nocase -quiet}
-  check_argc_eq0or1 "get_lib_cells" $args
   check_nocase_flag flags
 
   set regexp [info exists flags(-regexp)]
@@ -601,6 +596,7 @@ proc get_lib_cells { args } {
       lappend cells [$inst liberty_cell]
     }
   } else {
+    check_argc_eq1 "get_lib_cells" $args
     # Copy backslashes that will be removed by foreach.
     set patterns [string map {\\ \\\\} [lindex $args 0]]
     # Parse library_name/pattern.
@@ -838,7 +834,7 @@ proc get_nets { args } {
 
 define_cmd_args "get_pins" \
   {[-hierarchical] [-hsc separator] [-quiet] [-filter expr]\
-     [-regexp] [-nocase] [-of_objects objects] patterns}
+     [-regexp] [-nocase] [-of_objects objects] [patterns]}
 
 define_cmd_alias "get_pin" "get_pins"