From b30c82b2d0308973344d32434108c12b7ac50255 Mon Sep 17 00:00:00 2001 From: Jaehyun Kim Date: Mon, 6 Apr 2026 14:29:23 +0900 Subject: [PATCH] Make diff_files/diff_files_sorted error on mismatch Previously these functions returned 1 on mismatch but no caller checked the return value, allowing roundtrip failures to go undetected. Now they call error() so the sta process exits non-zero and the regression runner catches the failure. Co-Authored-By: Claude Signed-off-by: Jaehyun Kim --- test/helpers.tcl | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/test/helpers.tcl b/test/helpers.tcl index 01dab3d7..d2d4b60c 100644 --- a/test/helpers.tcl +++ b/test/helpers.tcl @@ -56,14 +56,10 @@ proc diff_files_sorted { file1 file2 } { } else { for {set i 0} {$i < [llength $lines1] && $i < [llength $lines2]} {incr i} { if { [lindex $lines1 $i] ne [lindex $lines2 $i] } { - puts "Differences found (sorted)." - puts "[lindex $lines1 $i]" - puts "[lindex $lines2 $i]" - return 1 + error "diff_files_sorted: $file1 vs $file2 differ at sorted line $i\n< [lindex $lines1 $i]\n> [lindex $lines2 $i]" } } - puts "Differences found (sorted): file lengths differ." - return 1 + error "diff_files_sorted: $file1 vs $file2 differ: file lengths differ" } } @@ -106,10 +102,7 @@ proc diff_files { file1 file2 { ignore "" } } { close $stream1 close $stream2 if { $found_diff || $line1_length != $line2_length } { - puts "Differences found at line $line." - puts "$line1" - puts "$line2" - return 1 + error "diff_files: $file1 vs $file2 differ at line $line\n< $line1\n> $line2" } else { puts "No differences found." return 0