From 7335731753ffcf99b68ddcd86ba3a1686569636b Mon Sep 17 00:00:00 2001
From: Ethan Mahintorabi <ethanmoon@google.com>
Date: Mon, 22 Apr 2024 21:54:12 +0000
Subject: [PATCH] Fixes memory leak in verilog attribute code.

There appears to be two leaks one with string handling, and
one with Dcl not freeing the attribute stmt list when it returns
nullptr.

Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
---
 verilog/VerilogParse.yy  | 9 +++++++--
 verilog/VerilogReader.cc | 5 ++++-
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/verilog/VerilogParse.yy b/verilog/VerilogParse.yy
index a7752bd6..17588bc3 100644
--- a/verilog/VerilogParse.yy
+++ b/verilog/VerilogParse.yy
@@ -505,9 +505,14 @@ attr_specs:
 
 attr_spec:
 	ID
-	{ $$ = new sta::VerilogAttributeEntry($1, "1"); }
+	{ $$ = new sta::VerilogAttributeEntry($1, "1");
+	  delete[] $1;
+	}
 | 	ID '=' attr_spec_value
-	{ $$ = new sta::VerilogAttributeEntry($1, $3); }
+	{ $$ = new sta::VerilogAttributeEntry($1, $3); 
+	  delete[] $1;
+	  delete[] $3;
+	}
 	;
 
 attr_spec_value:
diff --git a/verilog/VerilogReader.cc b/verilog/VerilogReader.cc
index c3649785..8980c7a0 100644
--- a/verilog/VerilogReader.cc
+++ b/verilog/VerilogReader.cc
@@ -424,8 +424,11 @@ VerilogReader::makeDcl(PortDirection *dir,
       dcl_count_++;
       return new VerilogDcl(dir, assign_args, attribute_stmts, line);
     }
-    else
+    else {
+      attribute_stmts->deleteContents();
+      delete attribute_stmts;
       return nullptr;
+    }
   }
   else {
     dcl_count_++;