From c65178f86c14cbbef87293019a7030fa232ffa94 Mon Sep 17 00:00:00 2001 From: Hunter Nichols Date: Mon, 27 Jul 2020 15:43:50 -0700 Subject: [PATCH 1/3] Fixed issue with sen delay measure getting mixed with voltage checks --- compiler/characterizer/delay.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/compiler/characterizer/delay.py b/compiler/characterizer/delay.py index b7faaec3..9d36fce7 100644 --- a/compiler/characterizer/delay.py +++ b/compiler/characterizer/delay.py @@ -185,8 +185,7 @@ class delay(simulation): self.sen_meas = delay_measure("delay_sen", self.clk_frmt, self.sen_name+"{}", "FALL", "RISE", measure_scale=1e9) self.sen_meas.meta_str = sram_op.READ_ZERO self.sen_meas.meta_add_delay = True - self.dout_volt_meas.append(self.sen_meas) - + return self.dout_volt_meas def create_read_bit_measures(self): From 9ea3616260820c2010316047a29916235d5ad0b8 Mon Sep 17 00:00:00 2001 From: Hunter Nichols Date: Mon, 27 Jul 2020 15:47:02 -0700 Subject: [PATCH 2/3] Changed multiport characterization warning to better fit --- compiler/characterizer/delay.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/characterizer/delay.py b/compiler/characterizer/delay.py index 9d36fce7..1fcd86f4 100644 --- a/compiler/characterizer/delay.py +++ b/compiler/characterizer/delay.py @@ -1350,7 +1350,7 @@ class delay(simulation): Return the analytical model results for the SRAM. """ if OPTS.num_rw_ports > 1 or OPTS.num_w_ports > 0 and OPTS.num_r_ports > 0: - debug.warning("Analytical characterization results are not supported for multiport.") + debug.warning("Analytical characterization for multiple read ports may be inaccurate.") # Probe set to 0th bit, does not matter for analytical delay. self.set_probe('0'*self.addr_size, 0) From b4dafac489d4f618bcb3fc080a97f5688e5f1fac Mon Sep 17 00:00:00 2001 From: Hunter Nichols Date: Mon, 27 Jul 2020 23:55:03 -0700 Subject: [PATCH 3/3] Fixed issue with sen measurement not being added --- compiler/characterizer/delay.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/characterizer/delay.py b/compiler/characterizer/delay.py index 1fcd86f4..afb9c7f6 100644 --- a/compiler/characterizer/delay.py +++ b/compiler/characterizer/delay.py @@ -186,7 +186,7 @@ class delay(simulation): self.sen_meas.meta_str = sram_op.READ_ZERO self.sen_meas.meta_add_delay = True - return self.dout_volt_meas + return self.dout_volt_meas + [self.sen_meas] def create_read_bit_measures(self): """ Adds bit measurements for read0 and read1 cycles """